Thread (6 messages) 6 messages, 3 authors, 2017-10-23

Re: [PATCH v2 31/37] mac80211_hwsim: Replace hrtimer tasklet with softirq hrtimer

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2017-10-23 10:26:00
Also in: lkml

On Mon, 2017-10-23 at 12:23 +0200, Thomas Gleixner wrote:
On Mon, 23 Oct 2017, Johannes Berg wrote:
quoted
On Sun, 2017-10-22 at 23:40 +0200, Anna-Maria Gleixner wrote:
quoted
From: Thomas Gleixner <redacted>

Switch the timer to HRTIMER_MODE_SOFT, which executed the timer
callback in softirq context and remove the hrtimer_tasklet.
I can't build as its part of the whole hrtimer rework series.
I guess you mean you *can* build it? Surely you're introducing the new
HR timer modes in some patch that I didn't see? :-)
quoted
quoted
+       hrtimer_init(&data->beacon_timer, CLOCK_MONOTONIC,
+                    HRTIMER_MODE_ABS_SOFT);
Sure, though it does not matter in that case. Will fix that up.
Right. Then again, why even pass it to init() and start()? Can you
start without going through start()?

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help