Re: [PATCH 3/3] mac80211: fix VLAN handling with TXQs
From: Toke Høiland-Jørgensen <toke@toke.dk>
Date: 2017-09-05 10:17:00
Johannes Berg [off-list ref] writes:
On Tue, 2017-09-05 at 11:49 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote:quoted
=20 Ah, so the station is attached to the VLAN interface, not the parent interface?Doesn't actually matter, but if the VLAN goes where the station belongs then either the station must've moved somewhere else or have been destroyed, you can't have the station pointing to a VLAN that no longer exists :)
Yeah, that makes sense. I was thinking of VLANs as something that was carried "on top" of the station<->ap connection (so that the VLAN tag is propagated to the client).
quoted
I guess that the only case where there is likely to be any significant effects of dropping the whole queue is if someone is sending large amounts of multicast traffic (live video streaming? is that even feasible over WiFi?) while reconfiguring their VLAN setup. That is probably not a terribly common combination...Right. Anyway I've applied this with the pointless null check removed.
Cool :) -Toke