Thread (8 messages) 8 messages, 5 authors, 2017-08-08

Re: [PATCH] iwlwifi: Demote messages about fw flags size to info

From: Luca Coelho <hidden>
Date: 2017-08-02 04:46:57
Also in: lkml, netdev

Hi João Paulo,


On Tue, 2017-08-01 at 15:58 -0700, João Paulo Rechi Vita wrote:
Hello Luca,

On Mon, Jul 24, 2017 at 4:01 AM, Coelho, Luciano
[off-list ref] wrote:
quoted
On Fri, 2017-07-21 at 07:51 -0700, João Paulo Rechi Vita wrote:
(...)
quoted
quoted
Currently these messages are presented to the user during boot if there
is no bootsplash covering the console, sometimes even if the boot splash
is enabled but has not started yet by the time this message is shown.
I should have provided another piece of information here: all of this
happens even when booting with the 'quiet' kernel parameter.
Oh, okay, that's annoying.

quoted
This specific case is harmless, but I'd rather keep this message as an
error, because in other situations it could lead to unexpected
behavioir, so I prefer to keep it very visible.
I see your point, and I understand the purpose of these messages. I'm
wondering if perhaps having them at the warning level would give them
enough visibility, while still keeping a clean boot process to the end
user. If so, I can send an updated patch.

Thanks for your reply and for pointing to the fix for the root cause
of that message.
Sure, I agree it's better to make it use IWL_WARN(), which will generate
a dev_warn() instead of a dev_err().


--
Cheers,
Luca.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help