Re: [v3,1/2] ath10k: add the PCI PM core suspend/resume ops
From: Kalle Valo <hidden>
Date: 2017-08-31 12:53:01
ryanhsu@qti.qualcomm.com wrote:
The actual PCI suspend/resume in ath10k has been handled in wow.c,
but in the case of the device doesn't support remote wakeup,
the .hif_suspend() and .hif_resume() will never be handled.
ath10k_wow_op_suspend()
{
if (WARN_ON(!test_bit(ATH10K_FW_FEATURE_WOWLAN_SUPPORT,
ar->running_fw->fw_file.fw_features))) {
ret = 1;
goto exit;
}
....
ret = ath10k_hif_suspend(ar);
}
So register the PCI PM core to support the suspend/resume if the device
doesn't support remote wakeup.
Signed-off-by: Ryan Hsu <redacted>
Signed-off-by: Kalle Valo <redacted>This had a warning: drivers/net/wireless/ath/ath10k/pci.c:3651:1: warning: symbol 'ath10k_pci_pm_ops' was not declared. Should it be static? I fixed it in the pending branch by making it static: static SIMPLE_DEV_PM_OPS(ath10k_pci_pm_ops, ath10k_pci_pm_suspend, ath10k_pci_pm_resume); Please review. -- https://patchwork.kernel.org/patch/9916215/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches