Re: [PATCH 3/5] qtnfmac: modify qtnf_map_bar not to return NULL

On Tue, Aug 29, 2017 at 07:13:35PM -0700, Igor Mitsyanko wrote:

On 08/29/2017 05:16 AM, Sergey Matyukevich wrote:

quoted

NULL is not a special type of success here but a error pointer.
So it makes sense to check against NULL in qtnf_map_bar
and return error code.

Signed-off-by: Sergey Matyukevich <redacted>
---

On a first glance not immediately obvious what is logically changed here, is
it so that pr_debug() would not print NULL pointer?

There is no actual bug here: all the mappings and error checks are in place.
This is more about coding style problem: when function return both NULL and
error pointeres, then the NULL is supposed to be a special type of success
return. In this particular case NULL is just yet another failure.