Re: [PATCH 2/2] iwlwifi: mvm: Avoid deffering non bufferable frames

On Tue, 2017-08-29 at 11:22 +0300, Kalle Valo wrote:

Luca Coelho [off-list ref] writes:

quoted

From: David Spinadel <redacted>

Use bcast station for all non bufferable frames on AP and AD-HOC.

The host is no longer aware of STAs PS status because of buffer
station offload, so we can't rely on mac80211 to toggle on
IEEE80211_TX_CTL_NO_PS_BUFFER bit.

A possible issue with buffering such frames, beside the obvious spec
violation, is when a station disconnects while in PS but the AP isn't
aware of that. In such scenarios the AP won't be able to send probe
responses or auth frames so the STA won't be able to reconnect and
the AP will have a queue hang.

Fixes: 3e56eadfb6a1 ("iwlwifi: mvm: implement AP/GO uAPSD support")
Signed-off-by: David Spinadel <redacted>
Signed-off-by: Luca Coelho <redacted>

"deffering"? Should it be deferring?

Yeah, sorry, I'll fix it before sending the pull-req.

--
Cheers,
Luca.