Re: [PATCH] mwifiex: correct IE parse during association
From: Kalle Valo <hidden>
Date: 2017-07-28 14:39:23
From: Kalle Valo <hidden>
Date: 2017-07-28 14:39:23
Xinming Hu [off-list ref] writes:
From: Xinming Hu <redacted> It is observed that some IEs get missed during association. This patch correct the old IE parse code. sme->ie will be store as wpa ie, wps ie, wapi ie and gen ie accordingly. Signed-off-by: Xinming Hu <redacted> Signed-off-by: Cathy Luo <redacted>
[...]
+ } else {
+ if (pvendor_ie->element_id ==
+ WLAN_EID_VENDOR_SPECIFIC) {
+ /* Test to see if it is a WPA IE,
+ * if not, then it is a gen IE
+ */
+ if (!memcmp(pvendor_ie->oui, wpa_oui,
+ sizeof(wpa_oui))) {
+ /* IE is a WPA/WPA2 IE so call
+ * set_wpa function
+ */
+ mwifiex_set_wpa_ie(priv,
+ (u8 *)pvendor_ie,
+ cur_ie_len);The indentation is getting ugly here. A helper function or similar would really make this more readable. [...]
+NEXT_IE:
Goto labels in lower case, please. -- Kalle Valo