Thread (1 message) 1 message, 1 author, 2017-06-01

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

From: Kalle Valo <hidden>
Date: 2017-06-01 04:16:27
Also in: lkml, netdev

Jia-Ju Bai [off-list ref] writes:
quoted
Did you actually observe the attempt to sleep under the spin lock,
or did you discover this using some tool? In other words, have
either of your patches been tested?
In fact, my reported bugs are found by a static analysis tool written
by me, and they are checked by my review of the driver code.
It's valuable information to add to the commit log how you found the
bug. If you check other wireless commits you can see comments like
"Found by spatch", "Coverity reported" quite frequently. So I recommend
that you also mention your tool in the commit log, makes understanding
the background of the patch easier.

-- 
Kalle Valo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help