Re: [PATCH] rtlwifi: Remove unnecessary conditions
From: Souptick Joarder <hidden>
Date: 2017-06-22 12:40:58
Hi Julian, On Thu, Jun 22, 2017 at 6:03 PM, Julian Calaby [off-list ref] wrote:
Hi Souptick, On Thu, Jun 22, 2017 at 9:16 PM, Souptick Joarder [off-list ref] wrote:quoted
As wmm_enable is initialized to false, hence the else condition never execute and boundary is assigned with TX_PAGE_BOUNDARY. So the if-else condition can be removed and boundary will be assigned with TX_PAGE_BOUNDARY. Signed-off-by: Souptick Joarder <redacted> --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c | 6 ------ 1 file changed, 6 deletions(-)diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c index f95a645..e9c5f6a 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c@@ -845,13 +845,7 @@ static int _rtl92cu_init_mac(struct ieee80211_hw *hw) pr_err("Failed to init power on!\n"); return err; } - if (!wmm_enable) { boundary = TX_PAGE_BOUNDARY;Firstly this isn't indented properly. Secondly, can this be moved up to where boundary is defined?
Sure. I will modify it and send in v2.
Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/
-Souptick