Re: brcmfmac: don't warn user if requested nvram fails

On 8 April 2017 at 11:53, Hans de Goede [off-list ref] wrote:

On 07-04-17 23:43, Arend Van Spriel wrote:

quoted

On 6-4-2017 14:14, Hans de Goede wrote:

quoted

I noticed your patch-series on the lwn.net kernel page,
and I took a peek :)

I don't think that this patch:


https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?h=20170329-driver-data-v2-try3&id=3968dd3031d1ff7e7be4acfb810948c70c2d4490


Is a good idea, specifically the "do not warn" part,
although the brcmfmac driver will indeed try to continue
without a nvram file, in my experience it almost all
the time will not work properly without the nvram file.

Actually, brcmfmac will only continue without nvram for PCIe devices.
For SDIO it is a different story, which may be the kind of devices you
have experienced.

Ah, no I've experience with both now, and the device I've
with a PCIE which needs nvram:

http://www.gpd.hk/gpdwin.asp

Will not work without the nvram file, so I really think
we should at least keep a warning msg here.

This is a late reply, I know...

I think you misunderstood my patch. It didn't completely remove the
warning. It just removed first try warning, where there is still a
chance of getting NVRAM from the platform data (special partition used
by bootloader & accessible by the operating system).

When both methods would fail, the warning would still appear.