Re: [PATCH 1/1] dt-binding: net: wireless: fix node name in the BCM43xx example

Hi Arend,

On Tue, May 16, 2017 at 12:05 AM, Arend Van Spriel
[off-list ref] wrote:

On 15-5-2017 22:13, Martin Blumenstingl wrote:

quoted

The example in the BCM43xx documentation uses "brcmf" as node name.
However, wireless devices should be named "wifi" instead. Fix this to

Hi Martin,

Since when is that a rule. I never got the memo and the DTC did not ever
complain to me about the naming. That being said I do not really care
and I suppose it is for the sake of consistency only.

I'm not sure if it's actually a rule or (as you already noted) just
for consistency. back when I added devicetree support to ath9k Rob
pointed out that the node should be named "wifi" (instead of "ath9k"),
see [0]

quoted

make sure that .dts authors can simply use the documentation as
reference (or simply copy the node from the documentation and then
adjust only the board specific bits).

Please feel free to add my...

Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>

thank you!

@Rob: maybe you can ACK this as well if you're fine with this patch?

quoted

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
 Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt
index 5dbf169cd81c..590f622188de 100644
--- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt
+++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt

@@ -31,7 +31,7 @@ mmc3: mmc@01c12000 {
      non-removable;
      status = "okay";

-     brcmf: bcrmf@1 {
+     brcmf: wifi@1 {
              reg = <1>;
              compatible = "brcm,bcm4329-fmac";
              interrupt-parent = <&pio>;

[0] http://www.mail-archive.com/ath9k-devel@lists.ath9k.org/msg14678.html