-----Original Message-----
From: ath10k [mailto:ath10k-bounces@lists.infradead.org] On Behalf Of Venka=
teswara Naralasettty
Sent: Monday, May 22, 2017 8:48 PM
To: Kalle Valo <redacted>; nbd@nbd.name
Cc: linux-wireless@vger.kernel.org; ath10k@lists.infradead.org
Subject: RE: [PATCH] ath10k : Fix channel survey dump


-----Original Message-----
From: Kalle Valo
Sent: Friday, May 19, 2017 2:48 PM
To: nbd@nbd.name
Cc: Venkateswara Naralasettty <redacted>; ath10k@lists.inf=
radead.org; linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k : Fix channel survey dump

Felix Fietkau [off-list ref] writes:

On 2017-04-26 16:41, Venkateswara Rao Naralasetty wrote:

quoted

Channel active/busy time are showing incorrect (less than previous or=20
sometimes zero) for successive survey dump command.
=20
example:
Survey data from wlan0
        frequency:                      5180 MHz [in use]
        channel active time:            54995 ms
        channel busy time:              432 ms
        channel receive time:           0 ms
        channel transmit time:          59 ms
Survey data from wlan0
        frequency:                      5180 MHz [in use]
        channel active time:            32592 ms
        channel busy time:              254 ms
        channel receive time:           0 ms
        channel transmit time:          0 ms
=20
This patch fix this issue by assigning 'wmi_bss_survey_req_type'
as 'WMI_BSS_SURVEY_REQ_TYPE_READ'.
=20
Firmware ver 10.4-3.4-00082
Hardware QCA4019
=20
Signed-off-by: Venkateswara Rao Naralasetty=20
[off-list ref]
---
 drivers/net/wireless/ath/ath10k/mac.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
=20

diff --git a/drivers/net/wireless/ath/ath10k/mac.c

b/drivers/net/wireless/ath/ath10k/mac.c
index 9977829..87a9b55 100644

--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c

@@ -6621,7 +6621,7 @@ static void ath10k_reconfig_complete(struct ieee80=

211_hw *hw,

quoted

 				  struct ieee80211_channel *channel)  {
 	int ret;
-	enum wmi_bss_survey_req_type type =3D WMI_BSS_SURVEY_REQ_TYPE_READ_CLE=

AR;

quoted

+	enum wmi_bss_survey_req_type type =3D WMI_BSS_SURVEY_REQ_TYPE_READ;

Does the firmware read the registers directly, or does it accumulate=20
the results in a way that can't overflow? If you don't clear the=20
counters on reset, the overflow will be problematic for the=20
current-channel stats. I think a better approach would be to use=20
READ_CLEAR for in-use channels and store the sum inside the driver.

Venkateswara, any comments?

--
Kalle Valo

Sorry for the delayed response I held up with some other work. Currently I =
am working with firmware team to address your comments.

--
Venkatesh.

Firmware is not handling the overflow while accumulating the results,  we=

 are looking into some other options to make it in host

-Venkatesh.

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
BLOCKEDlists[.]infradead[.]org/mailman/listinfo/ath10kBLOCKED