Thread (2 messages) 2 messages, 2 authors, 2017-02-08

Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2017-02-08 19:45:11
Also in: linux-mips, linux-nfs, linux-scsi, netdev

On 02/08/2017 08:11 AM, Kalle Valo wrote:
David Miller [off-list ref] writes:
quoted
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue,  7 Feb 2017 15:02:53 -0800
quoted
I'm hoping this doesn't conflict with what's already in net-next...

David, this should probably go via your tree considering the diffstat.
I think you need one more respin.  Are you doing an allmodconfig build?
I did not, instead tried to test each driver individually in different
configurations...
quoted
If not, for something like this it's a must:

drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected ‘)’ before ‘bool’
 module_param(disable_ap_sme, bool, 0444);
                              ^
drivers/net/wireless/ath/wil6210/cfg80211.c:25:34: error: expected ‘)’ before string constant
 MODULE_PARM_DESC(disable_ap_sme, " let user space handle AP mode SME");
                                  ^
Like like that file needs linux/module.h included.
Johannes already fixed a similar (or same) problem in my tree:

wil6210: include moduleparam.h

https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=949c2d0096753d518ef6e0bd8418c8086747196b

I'm planning to send you a pull request tomorrow which contains that
one.
Thanks Kalle!

David, can you hold on this series until Kalle's pull request gets
submitted? Past this error, allmodconfig builds fine with this patch
series (just tested). Thanks!
-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help