Thread (3 messages) 3 messages, 2 authors, 2017-02-27

Re: [PATCH 3/3] ath9k: ahb: Add OF support

From: Rafał Miłecki <zajec5@gmail.com>
Date: 2017-02-27 21:14:17
Also in: lkml

Why you didn't cc linux-wireless?!?!

On 27 February 2017 at 21:28, Alban [off-list ref] wrote:
quoted hunk
@@ -513,6 +515,43 @@ static void ath9k_eeprom_release(struct ath_softc *sc)
        release_firmware(sc->sc_ah->eeprom_blob);
 }

+#ifdef CONFIG_OF
+static int ath9k_init_of(struct ath_softc *sc)
+{
+       struct device_node *np = sc->dev->of_node;
+       struct ath_hw *ah = sc->sc_ah;
+       const void *macaddr;
+       struct clk *clk;
+       int ret = 0;
+
+       if (!np) {
+               dev_err(sc->dev, "no platform data or OF node\n");
+               return -EINVAL;
+       }
+
+       clk = clk_get(sc->dev, "ref");
+       if (!IS_ERR(clk)) {
+               ah->is_clk_25mhz = (clk_get_rate(clk) == 25000000);
+               clk_put(clk);
+       }
+
+       ah->disable_2ghz = of_property_read_bool(np, "qca,disable-2ghz");
+       ah->disable_5ghz = of_property_read_bool(np, "qca,disable-5ghz");
Please use ieee80211-freq-limit:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=b330b25eaabda00d74e47566d9200907da381896

Most likely with the wiphy_read_of_freq_limits helper:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e691ac2f75b69bee743f0370d79454ba4429b17

Example:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=0f83ff69735651cc7a3d150466a5257ff829b62b
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help