Re: [PATCH v2] staging: wilc1000: renames struct tstrRSSI and its members u8Index, u8Full
From: Arend Van Spriel <arend.vanspriel@broadcom.com>
Date: 2017-02-22 19:50:44
Also in:
lkml
On 22-2-2017 18:14, Tahia Khan wrote:
Fixes multiple camel case checks on struct tstrRSSI from checkpatch.pl: Avoid CamelCase: <tstrRSSI> Avoid CamelCase: <u8Full> Avoid CamelCase: <u8Index>
Just a generic remark that may help you with other changes you will be making in the linux kernel. Warnings from checkpatch.pl and other tools are useful, but try to look further than just fixing a warning. Understand what the code is doing is just as important.
quoted hunk ↗ jump to hunk
Signed-off-by: Tahia Khan <redacted> --- drivers/staging/wilc1000/coreconfigurator.h | 8 ++++---- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 +++++----- 2 files changed, 9 insertions(+), 9 deletions(-)diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h index cff1698..5b65c4f 100644 --- a/drivers/staging/wilc1000/coreconfigurator.h +++ b/drivers/staging/wilc1000/coreconfigurator.h@@ -70,9 +70,9 @@ enum connect_status { CONNECT_STS_FORCE_16_BIT = 0xFFFF }; -struct tstrRSSI { - u8 u8Full; - u8 u8Index; +struct tstr_RSSI { + u8 full; + u8 index; s8 as8RSSI[NUM_RSSI];
So you have a struct here with three members and you choose to only change the first two. What do you think about the third one just by looking at it. And what about the name of the struct. What does 'tstr' mean?
quoted hunk ↗ jump to hunk
};@@ -93,7 +93,7 @@ struct network_info { u8 *ies; u16 ies_len; void *join_params; - struct tstrRSSI str_rssi; + struct tstr_RSSI str_rssi; u64 tsf_hi; };diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c index f7ce47c..56f133e 100644 --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c@@ -205,8 +205,8 @@ static u32 get_rssi_avg(struct network_info *network_info) { u8 i; int rssi_v = 0; - u8 num_rssi = (network_info->str_rssi.u8Full) ? - NUM_RSSI : (network_info->str_rssi.u8Index); + u8 num_rssi = (network_info->str_rssi.full) ? + NUM_RSSI : (network_info->str_rssi.index);
so struct tstr_RSSI is really a rssi history buffer so maybe naming it as such makes it clearer, ie. struct rssi_history_buffer.
quoted hunk ↗ jump to hunk
for (i = 0; i < num_rssi; i++) rssi_v += network_info->str_rssi.as8RSSI[i];@@ -346,13 +346,13 @@ static void add_network_to_shadow(struct network_info *pstrNetworkInfo, } else { ap_index = ap_found; } - rssi_index = last_scanned_shadow[ap_index].str_rssi.u8Index; + rssi_index = last_scanned_shadow[ap_index].str_rssi.index; last_scanned_shadow[ap_index].str_rssi.as8RSSI[rssi_index++] = pstrNetworkInfo->rssi; if (rssi_index == NUM_RSSI) { rssi_index = 0; - last_scanned_shadow[ap_index].str_rssi.u8Full = 1; + last_scanned_shadow[ap_index].str_rssi.full = 1;
So the 'full' member is actually a bool and you might type it as such. Hope this helps. Regards, Arend
} - last_scanned_shadow[ap_index].str_rssi.u8Index = rssi_index; + last_scanned_shadow[ap_index].str_rssi.index = rssi_index; last_scanned_shadow[ap_index].rssi = pstrNetworkInfo->rssi; last_scanned_shadow[ap_index].cap_info = pstrNetworkInfo->cap_info; last_scanned_shadow[ap_index].ssid_len = pstrNetworkInfo->ssid_len;