Re: [Outreachy kernel] [PATCH] staging: wilc1000: renames struct tstrRSSI and its members u8Index, u8Full
From: Julia Lawall <hidden>
Date: 2017-02-22 07:19:40
Also in:
lkml
On Tue, 21 Feb 2017, Tahia Khan wrote:
quoted hunk ↗ jump to hunk
Fixes multiple camel case checks on struct tstrRSSI from checkpatch.pl: Avoid CamelCase: <tstrRSSI> Avoid CamelCase: <u8Full> Avoid CamelCase: <u8Index> Signed-off-by: Tahia Khan <redacted> --- drivers/staging/wilc1000/coreconfigurator.h | 8 ++++---- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 +++++----- 2 files changed, 9 insertions(+), 9 deletions(-)diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h index cff1698..c9cf23b 100644 --- a/drivers/staging/wilc1000/coreconfigurator.h +++ b/drivers/staging/wilc1000/coreconfigurator.h@@ -70,9 +70,9 @@ enum connect_status { CONNECT_STS_FORCE_16_BIT = 0xFFFF }; -struct tstrRSSI { - u8 u8Full; - u8 u8Index; +struct tstr_RSSI { + u8 u8_full; + u8 u8_index;
The kernel doesn't use variable names that incorporate types. These could just be full and index. julia
quoted hunk ↗ jump to hunk
s8 as8RSSI[NUM_RSSI]; };@@ -93,7 +93,7 @@ struct network_info { u8 *ies; u16 ies_len; void *join_params; - struct tstrRSSI str_rssi; + struct tstr_RSSI str_rssi; u64 tsf_hi; };diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c index f7ce47c..30285b9 100644 --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c@@ -205,8 +205,8 @@ static u32 get_rssi_avg(struct network_info *network_info) { u8 i; int rssi_v = 0; - u8 num_rssi = (network_info->str_rssi.u8Full) ? - NUM_RSSI : (network_info->str_rssi.u8Index); + u8 num_rssi = (network_info->str_rssi.u8_full) ? + NUM_RSSI : (network_info->str_rssi.u8_index); for (i = 0; i < num_rssi; i++) rssi_v += network_info->str_rssi.as8RSSI[i];@@ -346,13 +346,13 @@ static void add_network_to_shadow(struct network_info *pstrNetworkInfo, } else { ap_index = ap_found; } - rssi_index = last_scanned_shadow[ap_index].str_rssi.u8Index; + rssi_index = last_scanned_shadow[ap_index].str_rssi.u8_index; last_scanned_shadow[ap_index].str_rssi.as8RSSI[rssi_index++] = pstrNetworkInfo->rssi; if (rssi_index == NUM_RSSI) { rssi_index = 0; - last_scanned_shadow[ap_index].str_rssi.u8Full = 1; + last_scanned_shadow[ap_index].str_rssi.u8_full = 1; } - last_scanned_shadow[ap_index].str_rssi.u8Index = rssi_index; + last_scanned_shadow[ap_index].str_rssi.u8_index = rssi_index; last_scanned_shadow[ap_index].rssi = pstrNetworkInfo->rssi; last_scanned_shadow[ap_index].cap_info = pstrNetworkInfo->cap_info; last_scanned_shadow[ap_index].ssid_len = pstrNetworkInfo->ssid_len; --2.7.4 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. To post to this group, send email to outreachy-kernel@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170222045543.GA27847%40coolbox. For more options, visit https://groups.google.com/d/optout.