Re: [PATCH V3 2/2] brcmfmac: don't warn user about NVRAM if fallback to platform one succeeds

Arend Van Spriel [off-list ref] writes:

On 21-2-2017 10:47, Rafa=C5=82 Mi=C5=82ecki wrote:

quoted

From: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
=20
Failing to load NVRAM file isn't critical if we manage to get platform
one in the fallback path. It means warnings like:
[ 10.801506] brcmfmac 0000:01:00.0: Direct firmware load for
brcm/brcmfmac43602-pcie.txt failed with error -2
are unnecessary & disturbing for people with platform NVRAM. This is
very common case for Broadcom home routers.
=20
So instead of printing warning immediately with the firmware subsystem
let's first try our fallback code. If that fails as well, then it's a
right moment to print an error.
=20
This should reduce amount of false reports from users seeing this
warning while having wireless working perfectly fine.

I think FW_OPT_NO_WARN does not cover all warnings in firmware_class
although I did not check. Anyway...

Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>

Acked-by: Kalle Valo <redacted>

Feel free to this via some another tree.

--=20
Kalle Valo