Re: [PATCH 2/2] brcmfmac: don't warn user if loading firmware file with NVRAM fails
From: Andy Shevchenko <hidden>
Date: 2017-02-16 01:19:06
Also in:
lkml
On Thu, Feb 16, 2017 at 12:29 AM, Rafa=C5=82 Mi=C5=82ecki <zajec5@gmail.com=
wrote: From: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl> This isn't critical as we use platform NVRAM as fallback and it's very common case of all Broadcom home routers. Thanks for the new firmware loading function we can achieve this by simply passing FW_OPT_NO_WARN.
What kind of warning you are talking about? On Intel Edison brcmfmac isn't backed up by NVRAM (there no such) and the platform is not ACPI-based. The warning might be crucial for debugging Wi-Fi issues on such platforms.
Signed-off-by: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl> --- Kalle, Arend: this patch is strictly related to the bigger 1/2. Could you=
ack
quoted hunk ↗ jump to hunk
this change as I expect this patchset to be picked by Ming, Luis or Greg. --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c =
b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c
quoted hunk ↗ jump to hunk
index c7c1e9906500..26ec445a8d2d 100644--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c@@ -504,9 +504,9 @@ static void brcmf_fw_request_code_done(const struct f=
irmware *fw, void *ctx)
return;
}
fwctx->code =3D fw;
- ret =3D request_firmware_nowait(THIS_MODULE, true, fwctx->nvram_n=ame,
- fwctx->dev, GFP_KERNEL, fwctx, - brcmf_fw_request_nvram_done); + ret =3D request_firmware_async(THIS_MODULE, FW_OPT_NO_WARN, + fwctx->nvram_name, fwctx->dev, GFP_K=
ERNEL,
+ fwctx, brcmf_fw_request_nvram_done);
if (!ret)
return;
--
2.11.0--=20 With Best Regards, Andy Shevchenko