Re: [PATCH] Make EN2 pin optional in the TRF7970A driver
From: Rob Herring <robh@kernel.org>
Date: 2017-02-10 15:58:29
Also in:
linux-devicetree, lkml, netdev
From: Rob Herring <robh@kernel.org>
Date: 2017-02-10 15:58:29
Also in:
linux-devicetree, lkml, netdev
On Tue, Feb 07, 2017 at 06:22:04AM +0100, Heiko Schocher wrote:
From: Guan Ben <redacted> Make the EN2 pin optional. This is useful for boards, which have this pin fix wired, for example to ground. Signed-off-by: Guan Ben <redacted> Signed-off-by: Mark Jonas <redacted> Signed-off-by: Heiko Schocher <redacted> --- .../devicetree/bindings/net/nfc/trf7970a.txt | 4 ++-- drivers/nfc/trf7970a.c | 26 ++++++++++++---------- 2 files changed, 16 insertions(+), 14 deletions(-)diff --git a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt index 32b35a0..5889a3d 100644 --- a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt +++ b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt@@ -5,8 +5,8 @@ Required properties: - spi-max-frequency: Maximum SPI frequency (<= 2000000). - interrupt-parent: phandle of parent interrupt handler. - interrupts: A single interrupt specifier. -- ti,enable-gpios: Two GPIO entries used for 'EN' and 'EN2' pins on the - TRF7970A. +- ti,enable-gpios: One or two GPIO entries used for 'EN' and 'EN2' pins on the + TRF7970A. EN2 is optional.
Could EN ever be optional/fixed? If so, perhaps deprecate this property and do 2 properties, one for each pin. Rob