Re: [PATCH 2/2][RFC] mac80211_hwsim: Report radio addresses in NEW_RADIO/GET_RADIO
From: Andrew Zaborowski <hidden>
Date: 2017-02-28 01:24:25
Hi, On 27 February 2017 at 18:10, Ben Greear [off-list ref] wrote:
On 02/27/2017 07:26 AM, Andrew Zaborowski wrote:quoted
As it turns out it can be read from /sys, but I do need it so I can know what to put in HWSIM_ATTR_ADDR_RECEIVER based on the destination addr in the frame or if I want to forward the frame to all radios. Or is there another way to know that?quoted
I'd actually prefer to *only* have the wiphy index, and I don't really see a problem with moving the wiphy_idx from struct cfg80211_registered_device to struct wiphy.Ok, I'll try that. get_wiphy_idx can stay in place, not sure if I should just drop it. By having *only* the wiphy index you don't mean dropping the radio names altogether? The don't seem useful but userspace may expect them.I find the name and addr more useful than an 'index', because if you remove/add a virtual phy, then the index will probably change, even if name and MAC
I don't think you can remove/add a phy without removing the hwsim radio. A hwsim radio is tied to some wiphy at all times.
addr may stay the same (and so probably be the same logical entitity).
They may stay the same or not, you can't assume either. Sorry I don't understand your point. Best regards