Re: [PATCH v3 1/2] mac80211: fils_aead: Use crypto api CMAC shash rather than bare cipher
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2017-02-08 07:00:27
Also in:
netdev
This looks strange to me:
+static int aes_s2v(struct crypto_shash *tfm,
size_t num_elem, const u8 *addr[], size_t len[],
u8 *v)
{
- u8 d[AES_BLOCK_SIZE], tmp[AES_BLOCK_SIZE];
+ u8 d[AES_BLOCK_SIZE], tmp[AES_BLOCK_SIZE] = {};
+ SHASH_DESC_ON_STACK(desc, tfm);desc declared
+ crypto_shash_digest(desc, tmp, AES_BLOCK_SIZE, d);
used here
+ crypto_shash_init(desc);
but initialized now? johannes