Re: [PATCH 2/3] ath10k: use dma_zalloc_coherent()
From: Joe Perches <joe@perches.com>
Date: 2017-01-23 23:19:34
Also in:
lkml, netdev
On Mon, 2017-01-23 at 15:04 +0000, Srinivas Kandagatla wrote:
use dma_zalloc_coherent() instead of dma_alloc_coherent and memset().
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
[]
quoted hunk ↗ jump to hunk
@@ -896,7 +896,7 @@ static int ath10k_pci_diag_read_mem(struct ath10k *ar, u32 address, void *data, */ alloc_nbytes = min_t(unsigned int, nbytes, DIAG_TRANSFER_LIMIT); - data_buf = (unsigned char *)dma_alloc_coherent(ar->dev, + data_buf = (unsigned char *)dma_zalloc_coherent(ar->dev, alloc_nbytes, &ce_data_base, GFP_ATOMIC);
trivia: Nicer to realign arguments and remove the unnecessary cast. Perhaps: data_buf = dma_zalloc_coherent(ar->dev, alloc_nbytes, &ce_data_base, GFP_ATOMIC);