Re: mwifiex: fix uninitialized variable access in pcie_remove
From: Kalle Valo <hidden>
Date: 2017-01-17 11:56:07
Also in:
lkml, netdev
Arnd Bergmann [off-list ref] wrote:
Checking the firmware status from PCIe register only works
if the register is available, otherwise we end up with
random behavior:
drivers/net/wireless/marvell/mwifiex/pcie.c: In function 'mwifiex_pcie_remove':
drivers/net/wireless/marvell/mwifiex/pcie.c:585:5: error: 'fw_status' may be used uninitialized in this function [-Werror=maybe-uninitialized]
This makes sure we treat the absence of the register as a failure.
Fixes: 045f0c1b5e26 ("mwifiex: get rid of global user_rmmod flag")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>Patch applied to wireless-drivers-next.git, thanks. 0e8edb9aed03 mwifiex: fix uninitialized variable access in pcie_remove -- https://patchwork.kernel.org/patch/9515899/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches