Thread (8 messages) 8 messages, 3 authors, 2017-01-27

Re: [PATCH] nl80211: fix validation of scheduled scan info for wowlan netdetect

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2017-01-24 08:57:36

On Thu, 2017-01-19 at 14:08 +0100, Arend Van Spriel wrote:
On 19-1-2017 13:00, Luca Coelho wrote:
quoted
On Thu, 2017-01-19 at 10:01 +0000, Arend van Spriel wrote:
quoted
For wowlan netdetect a separate limit is defined for the number
of
matchsets. Currently, this limit is ignored and the regular limit
for scheduled scan matchsets, ie. struct wiphy::max_match_sets,
is
used for the net-detect case as well.

Cc: Luciano Coelho <redacted>
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
---
What?! You don't have the same number of matchsets for both? :P
Actually I have, but your comment mentioned they do not have to be
the
same. brcmfmac actually did not set max_nd_match_sets so I was
surprised
it worked. That said this patch will result in regression in brcmfmac
:-p Not sure about other drivers supporting net-detect.
So do you want to submit a patch to brcmfmac first, and then I'll apply
this later? I can apply it and break it, but now that we already know
...?

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help