Kalle Valo [off-list ref] writes:

Kalle Valo [off-list ref] writes:

quoted

"Valo, Kalle" [off-list ref] writes:

quoted

Bjorn Andersson [off-list ref] writes:

quoted

On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote:

quoted

Bjorn Andersson [off-list ref] wrote:

quoted

The correct include file for getting errno constants and ERR_PTR() =

is

quoted

quoted

quoted

quoted

quoted

linux/err.h, rather than linux/errno.h, so fix the include.
=20
Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled=

 smem_state")

quoted

quoted

quoted

quoted

quoted

Acked-by: Andy Gross <redacted>
Signed-off-by: Bjorn Andersson <redacted>

=20
For some reason this fails to compile now. Can you take a look, pleas=

e?

quoted

quoted

quoted

quoted

=20
ERROR: "qcom_wcnss_open_channel" [drivers/net/wireless/ath/wcn36xx/wc=

n36xx.ko] undefined!

quoted

quoted

quoted

quoted

make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
=20
5 patches set to Changes Requested.
=20
9429045 [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()
9429047 [v5,2/5] wcn36xx: Transition driver to SMD client

This patch was updated with the necessary depends in Kconfig to catch
this exact issue and when I pull in your .config (which has QCOM_SMD=

=3Dn,

quoted

quoted

quoted

QCOM_WCNSS_CTRL=3Dn and WCN36XX=3Dy) I can build this just fine.

I've tested the various combinations and it seems to work fine. Do you
have any other patches in your tree?

This was with the pending branch of my ath.git tree. There are other
wireless patches (ath10k etc) but I would guess they don't affect here.

quoted

Any stale objects?

Not sure what you mean with this question, but I didn't run 'make clean=

'

quoted

quoted

if that's what you are asking.

quoted

Would you mind retesting this, before I invest more time in trying to
reproduce the issue you're seeing?

Sure, I'll take a look but that might take few days.

I didn't find enough time to look at this in detail. I applied this to
my ath.git pending branch, let's see what the kbuild bot finds.

It found the same problem. Interestingly I'm also building x86 with 32
bit, maybe it's related?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pen=

ding

head:   1ea16a1c457939b4564643f7637d5cc639a8d3b7
commit: 5eb09c672b01460804fd49b1c9cc7d1072a102f0 [96/99] wcn36xx: Transit=

ion driver to SMD client

config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        git checkout 5eb09c672b01460804fd49b1c9cc7d1072a102f0
        # save the attached .config to linux build tree
        make ARCH=3Di386=20

All errors (new ones prefixed by >>):

quoted

quoted

ERROR: "qcom_wcnss_open_channel" [drivers/net/wireless/ath/wcn36xx/wcn3=

6xx.ko] undefined!

Bjorn mentioned me on IRC that this is because of a missing commit in my
tree:

daa6e41ce2b5 soc: qcom: wcnss_ctrl: Stub wcnss_ctrl API

When I pull the tag below (which contains the above commit) wcn36xx
builds fine for me:

git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git tags/qcom-dr=
ivers-for-4.10

Andy, is it ok if I pull your tag also to my ath.git tree to solve the
wcn36xx build problem? My trees go to Linus via net-next and I don't
know when exactly Dave would send a pull request to Linus, before or
after the arm trees, but as the tag seems to contain only few patches I
hope it doesn't matter.

--=20
Kalle Valo=