Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()
From: Valo, Kalle <hidden>
Date: 2016-11-22 14:55:14
Also in:
linux-arm-msm, lkml, netdev
Bjorn Andersson [off-list ref] writes:
On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote:quoted
Bjorn Andersson [off-list ref] wrote:quoted
The correct include file for getting errno constants and ERR_PTR() is linux/err.h, rather than linux/errno.h, so fix the include. =20 Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled sm=
em_state")
quoted
quoted
Acked-by: Andy Gross <redacted> Signed-off-by: Bjorn Andersson <redacted>=20 For some reason this fails to compile now. Can you take a look, please? =20 ERROR: "qcom_wcnss_open_channel" [drivers/net/wireless/ath/wcn36xx/wcn36=
xx.ko] undefined!
quoted
make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2 =20 5 patches set to Changes Requested. =20 9429045 [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() 9429047 [v5,2/5] wcn36xx: Transition driver to SMD clientThis patch was updated with the necessary depends in Kconfig to catch this exact issue and when I pull in your .config (which has QCOM_SMD=3Dn, QCOM_WCNSS_CTRL=3Dn and WCN36XX=3Dy) I can build this just fine. I've tested the various combinations and it seems to work fine. Do you have any other patches in your tree?
This was with the pending branch of my ath.git tree. There are other wireless patches (ath10k etc) but I would guess they don't affect here.
Any stale objects?
Not sure what you mean with this question, but I didn't run 'make clean' if that's what you are asking.
Would you mind retesting this, before I invest more time in trying to reproduce the issue you're seeing?
Sure, I'll take a look but that might take few days. --=20 Kalle Valo=