Re: [PATCH 2/3] ath9k: export configurable parameters of PTA
From: Valo, Kalle <hidden>
Date: 2016-11-25 15:28:22
miaoqing@codeaurora.org writes:
From: Miaoqing Pan <redacted> Export time_extend, pritority_time, first_slot_time, wl_active_time and wl_qc_time those PTA(aka slotted mode) configurable parameters, allow user to change/debug the timing easily. Also set wl_active_time and wl_qc_time default value to 0, as in this period WLAN chip may send out ACK, and it will corrupt the BT(or other) received packet in the PTA cycle. Signed-off-by: Miaoqing Pan <redacted>
Please try to always write commit logs so that everyone will understand, for example spelling out what PTA means would be nice.
quoted hunk ↗ jump to hunk
--- a/drivers/net/wireless/ath/ath9k/init.c +++ b/drivers/net/wireless/ath/ath9k/init.c@@ -77,6 +77,26 @@ struct ath9k_eeprom_ctx { static int ath9k_btcoex_duty_cycle =3D ATH_BTCOEX_DEF_DUTY_CYCLE; module_param_named(btcoex_duty_cycle, ath9k_btcoex_duty_cycle, int, 0444=
);
MODULE_PARM_DESC(btcoex_duty_cycle, "BT coexistence duty cycle"); + +static int ath9k_btcoex_time_extend; +module_param_named(btcoex_time_extend, ath9k_btcoex_time_extend, int, 04=
44);
+MODULE_PARM_DESC(btcoex_time_extend, "BT coexistence time extend"); + +static int ath9k_btcoex_priority_time =3D 2; +module_param_named(btcoex_priority_time, ath9k_btcoex_priority_time, int=
, 0444);
+MODULE_PARM_DESC(btcoex_priority_time, "BT coexistence priority time"); + +static int ath9k_btcoex_first_slot_time =3D 5; +module_param_named(btcoex_first_slot_time, ath9k_btcoex_first_slot_time,=
int, 0444);
+MODULE_PARM_DESC(btcoex_first_slot_time, "BT coexistence first slot time=
");
+ +static int ath9k_btcoex_wl_active_time; +module_param_named(btcoex_wl_active_time, ath9k_btcoex_wl_active_time, i=
nt, 0444);
+MODULE_PARM_DESC(btcoex_wl_active_time, "BT coexistence wlan active time=
");
+ +static int ath9k_btcoex_wl_qc_time; +module_param_named(btcoex_wl_qc_time, ath9k_btcoex_wl_qc_time, int, 0444=
);
+MODULE_PARM_DESC(btcoex_wl_qc_time, "BT coexistence wlan quiet collision=
time");
#endif
Same as with the previous patch, I don't think these should be set via module parameters. --=20 Kalle Valo=