Re: [19/28] brcmfmac: avoid maybe-uninitialized warning in brcmf_cfg80211_start_ap
From: Kalle Valo <hidden>
Date: 2016-10-27 15:07:03
Also in:
lkml, netdev
From: Kalle Valo <hidden>
Date: 2016-10-27 15:07:03
Also in:
lkml, netdev
Arnd Bergmann [off-list ref] wrote:
A bugfix added a sanity check around the assignment and use of the
'is_11d' variable, which looks correct to me, but as the function is
rather complex already, this confuses the compiler to the point where
it can no longer figure out if the variable is always initialized
correctly:
brcm80211/brcmfmac/cfg80211.c: In function ‘brcmf_cfg80211_start_ap’:
brcm80211/brcmfmac/cfg80211.c:4586:10: error: ‘is_11d’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
This adds an initialization for the newly introduced case in which
the variable should not really be used, in order to make the warning
go away.
Fixes: b3589dfe0212 ("brcmfmac: ignore 11d configuration errors")
Cc: Hante Meuleman <redacted>
Cc: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: Kalle Valo <redacted>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>Patch applied to wireless-drivers.git, thanks. d3532ea6ce4e brcmfmac: avoid maybe-uninitialized warning in brcmf_cfg80211_start_ap -- https://patchwork.kernel.org/patch/9380763/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches