Re: [PATCH v4 2/4] wcn36xx: Transition driver to SMD client
From: Kalle Valo <hidden>
Date: 2016-09-09 05:17:20
Also in:
linux-arm-msm, lkml, netdev
Andy Gross [off-list ref] writes:
quoted
quoted
quoted
quoted
This doesn't compile for me:I thought I mentioned this in the mail, sorry for missing that.Maybe you did and I just forgot, I have a tendency to do that :)quoted
There is a patch for this issue in linux-next already [1] which is part of [2], which was part of the pull request to arm-soc for inclusion in v4.9. [1] https://patchwork.kernel.org/patch/9272457/ [2] https://git.kernel.org/cgit/linux/kernel/git/agross/linux.git/tag/?h=qcom-drivers-for-4.9So the commit in question is: soc: qcom: smd: Correct compile stub prototypes https://git.kernel.org/cgit/linux/kernel/git/agross/linux.git/commit/?h=qcom-drivers-for-4.9&id=3a1281848830fcb3202cfd7ffe62d19641471d05Correctquoted
But that's not obviously in my tree yet, but I should have it after 4.9-rc1 is released. I think it's easiest that I wait for that before applying these. Do you agree?Would be nice to have it land sooner rather than later, but I'm okay with this.We could just treat the tag as immutable. You can merge the tag in and arm-soc can as well. it'll just get nop'd the second time it is taken. The only downside is if arm-soc doesn't take my merge request.
I take it that you are talking about this tag: git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git qcom-drivers-for-4.9 I did a test pull and there are only 8 commits so in theory that could work. But my trees go via Dave Miller's net-next so I can't control when they hit Linus' tree. It might be that Linus pulls the net-next tree before arm-soc and arm-soc commits coming from net-next might confuse people. I'm just afraid that the hassle would outweight the benefit.
Or we can wait till -rc1
To keep things simple I prefer this option. Of course it means waiting few more extra weeks, but when working with new subsystems that can happen. The crystall ball[1] says that 4.9-rc1 would be released on 2016-10-16 so it's not that far away. [1] http://phb-crystal-ball.org/ -- Kalle Valo