Thread (1 message) 1 message, 1 author, 2016-09-03

Re: fix:rtl8xxxu_core: mark symbols static where possible

From: Jes Sorensen <hidden>
Date: 2016-09-03 12:32:02
Also in: lkml, netdev

Kalle Valo [off-list ref] writes:
Baoyou Xie [off-list ref] wrote:
quoted
We get 1 warning about global functions without a declaration
in the rtl8xxxu rtl8xxxu_core.c when building with W=1:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:898:1:
warning: no previous prototype for 'rtl8xxxu_gen1_h2c_cmd'
[-Wmissing-prototypes]

In fact, this function is only used in the file in which it is declared
and don't need a declaration, but can be made static.
so this patch marks it 'static'.

Signed-off-by: Baoyou Xie <redacted>
The title should be "rtl8xxxu: ". See:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject_name

Also I assume Jes will take this.
Yes to both accounts!

Thanks,
Jes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help