On Sun, 2016-08-07 at 17:49 +0100, Ben Hutchings wrote:
I'm looking at commit 3d5fdff46c4b as part of the stable process.
The path it touches is only used for drivers that don't describe
their private wext handlers, right? So how can we know that the
private ioctl is using the iw_point structure and not one of the
other types in union iwreq_data? Doesn't this result in a regression
when another type is being used?
Crap, that's good point. I'll revert the patch.
Fortunately this code path is never actually used. The only "mainline"
driver that appears to use it is staging/wilc1000.
I wonder if we should just remove it entirely. Yes, it'd break that
staging driver to some extent, but it's clearly an unsafe code path.
Prasun, did you need this for the mwifiex wext ioctl support that was
shot down anyway?
johannes