Thread (10 messages) 10 messages, 4 authors, 2016-09-04

Re: linux-4.8-rc3/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:3533: pointless test ?

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2016-08-22 14:30:14
Also in: lkml

On Mon, Aug 22, 2016 at 03:07:44PM +0100, David Binderman wrote:
Hello there,

linux-4.8-rc3/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:3533]:
(style) Condition 'pBtMgnt.ExtConfig.HCIExtensionVer>=1' is always
true

Source code is

        if (pBtMgnt->ExtConfig.HCIExtensionVer < 1) {
        ....
        } else if (pBtMgnt->ExtConfig.HCIExtensionVer >= 1) {

Suggest remove second test.
patches are always welcome :)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help