Re: [PATCH] nl80211: Fix unfiltered GET_INTERFACE dumps
From: Arend van Spriel <arend.vanspriel@broadcom.com>
Date: 2016-08-25 22:30:00
On 25-08-16 22:44, Denis Kenzior wrote:
dump_wiphy_parse only assigns filter_wiphy if one of the supported NL80211 attributes is present. So for unfiltered dumps, filter_wiphy was always initialized to 0, and only interface 0 was dumped. This was introduced in commit 2d75da13fbb957e955d212555b91101cef36f0ce. Reported-by: Arend Van Spriel <arend.vanspriel@broadcom.com>
Actually sent a patch for this issue a little earlier. I should have Cc'ed you explicitly, I guess. Regards, Arend
quoted hunk ↗ jump to hunk
Signed-off-by: Denis Kenzior <redacted> --- net/wireless/nl80211.c | 1 + 1 file changed, 1 insertion(+)diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 95d55d2..ddc994a 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c@@ -2534,6 +2534,7 @@ static int nl80211_dump_interface(struct sk_buff *skb, struct netlink_callback * struct nl80211_dump_wiphy_state state = {}; int ret; + state.filter_wiphy = -1; ret = nl80211_dump_wiphy_parse(skb, cb, &state); if (ret) return ret;