Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On Thu, Jul 14, 2016 at 09:44:22AM +0000, Grumbach, Emmanuel wrote:

quoted

If I understad correctly this error happen 100% of the time, not only during
init. Hence seems there is an issue here, i.e. cur_ucode is not marked
correctly as IWL_UCODE_REGULAR or iwl_mvm_get_temp() fail 100% of the
time (iwl_mvm_is_tt_in_fw() incorrecly return true on Prarit device ? ).

Cur_ucode will not be IWL_UCODE_REGULAR until you load the firmware which
will happen upon ifup.

Then creating thermal_device on ifup looks more reasonable to me.
Otherwise we can create device that can be non-functional virtually
forever, i.e. when soft RFKILL is enabled. However I admit that
creating thermal_device when HW is detected has some advantages
too.

Stanislaw