Thread (1 message) 1 message, 1 author, 2016-07-08

Re: [RFC 5/7] net: Add allocation flag to rtnl_unicast()

From: Eric Dumazet <hidden>
Date: 2016-07-08 04:00:31
Also in: linux-rdma, netdev, netfilter-devel

On Fri, 2016-07-08 at 12:15 +0900, Masashi Honma wrote:
=
Thanks for comment.

I have selected GFP flags based on existing code.

I have selected GFP_ATOMIC in inet6_netconf_get_devconf() because
skb was allocated with GFP_ATOMIC.
Point is : we should remove GFP_ATOMIC uses as much as we can.

Everytime we see one of them, we should think why it was added
and if this is really needed.

inet6_netconf_get_devconf() is a perfect example of one careless
GFP_ATOMIC usage

https://patchwork.ozlabs.org/patch/646291/





Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help