Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-18

Re: mwifiex: fix link error against sdio

From: Kalle Valo <hidden>
Date: 2016-06-18 13:36:54
Also in: lkml, netdev

Arnd Bergmann [off-list ref] wrote:
Calling sdio_claim_host() from the interface independent part of
the mwifiex driver is not only a layering violation, but also causes
a link error if MMC support is disabled, or if CONFIG_MMC=m
and CONFIG_MWIFIEX=y:

drivers/net/built-in.o: In function `mwifiex_fw_dpc':
:(.text+0xff138): undefined reference to `sdio_claim_host'
:(.text+0xff158): undefined reference to `sdio_release_host'

The right way to do this is to have the sdio specific code in the
sdio driver front-end, and we already have a callback pointer that
we can use for this after exporting the generic fw download
function from the core driver.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 65c71efe1c59 ("mwifiex: fix racing condition when downloading firmware")
Thanks, 1 patch applied to wireless-drivers-next.git:

2095b1426c9c mwifiex: fix link error against sdio

-- 
Sent by pwcli
https://patchwork.kernel.org/patch/9180095/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help