Thread (3 messages) 3 messages, 3 authors, 2016-06-15

Re: [PATCH] hsi: Build hsi_boardinfo.c into hsi core if enabled

From: Sebastian Reichel <sre@kernel.org>
Date: 2016-06-15 12:48:51
Also in: linux-gpio, linux-i2c, linux-leds, linux-media, linux-mmc, linux-pwm, linuxppc-dev, lkml

Hi Andrew,

On Tue, Jun 14, 2016 at 11:13:04AM -0500, Andrew F. Davis wrote:
If the HSI core is built as a module hsi_boardinfo may still
be built-in as its Kconfig type is bool, which can cause build
issues. Fix this by building this code into the HSI core when
enabled.

Reported-by: kbuild test robot <redacted>
Signed-off-by: Andrew F. Davis <redacted>
---
This build error seems to be due to Kconfig symbol CONFIG_HSI_BOARDINFO
being a bool but depending on a tristate (CONFIG_HSI). This is normally
okay when it is just a flag to enable a feature in source, but the
helper code file hsi_boardinfo.c is built as a separate entity when
enabled. This patch is probably how it was intended, and is more like
how others do this kind of thing.

This patch should be applied before the parent patch:
Thanks, I applied both patches.

-- Sebastian

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help