Re: [PATCH 7/8] mwifiex: don't print an error if an optional DT property is missing
From: Julian Calaby <hidden>
Date: 2016-06-01 04:21:18
Also in:
lkml, netdev
From: Julian Calaby <hidden>
Date: 2016-06-01 04:21:18
Also in:
lkml, netdev
Hi All, On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas [off-list ref] wrote:
The Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt DT binding document say that the "interrupts" property in the child node is optional. So the property being missed shouldn't be treated as an error.
Have you checked whether it is truly optional? I.e. nothing else breaks if this property isn't set?
Signed-off-by: Javier Martinez Canillas <redacted>
Other than that, this looks sensible to me. Reviewed-by: Julian Calaby <redacted>
--- drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/