Re: [wireless-drivers-next:master 13/19] main.c:undefined reference to `sdio_claim_host'
From: Kalle Valo <hidden>
Date: 2016-06-16 11:51:08
Wei-Ning Huang [off-list ref] writes:
Hi Kalle,
Please send mails to the list, not to me privately
This patch is replaced by a new version: https://patchwork.kernel.org/patch/ 9138245/ and should build fine.
[...]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ wireless-drivers-next.git master head: c62d50a4062e586855a68c3acfbc2a2c299270cd commit: 65c71efe1c59c111a7b9e6d9540f111663b975b2 [13/19] mwifiex: fix racing condition when downloading firmware config: x86_64-randconfig-s1-06151332 (attached as .config) compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430 reproduce: git checkout 65c71efe1c59c111a7b9e6d9540f111663b975b2 # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/built-in.o: In function `mwifiex_fw_dpc': >> main.c:(.text+0x496d83): undefined reference to `sdio_claim_host' >> main.c:(.text+0x496da8): undefined reference to `sdio_release_host'
So I accidentally commited v1 when there was v2 available? It would have been a very good idea to send a _public_ reply to v1 that I should drop it, that avoids mistakes like this. v1: https://patchwork.kernel.org/patch/9123771/ v2: https://patchwork.kernel.org/patch/9138245/ There was no changelog (always add that!), what changed in v2? I see that Arnd already sent a fix for this patch. Is that enough or do we need more? mwifiex: fix link error against sdio https://patchwork.kernel.org/patch/9180095/ -- Kalle Valo