Thread (3 messages) 3 messages, 3 authors, 2016-03-23

Re: [PATCH] rtlwifi: fix gcc-6 indentation warning

From: Larry Finger <hidden>
Date: 2016-03-17 16:09:46
Also in: lkml, netdev

On 03/17/2016 05:03 AM, Arnd Bergmann wrote:
quoted hunk ↗ jump to hunk
The rtl8821ae_dm_txpower_tracking_callback_thermalmeter function
contains a call to RT_TRACE() that is indented in a misleading
way, as pointed out by a gcc-6 warning:

drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c: In function 'rtl8821ae_dm_txpower_tracking_callback_thermalmeter':
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:2491:4: error: statement is indented as if it were guarded by...
     RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,
     ^~~~~~~~
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:2488:3: note: ...this 'for' clause, but it is not
    for (p = RF90_PATH_A; p < MAX_PATH_NUM_8821A; p++)
    ^~~

It is clear from the context that the call was not meant to be
part of the loop and only the indentation is wrong, so this
removes the extra tabs.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
  drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c
index 95dcbff4673b..6a8245c4ea48 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c
@@ -2488,9 +2488,9 @@ void rtl8821ae_dm_txpower_tracking_callback_thermalmeter(
  		for (p = RF90_PATH_A; p < MAX_PATH_NUM_8821A; p++)
  			rtldm->swing_idx_ofdm_base[p] = rtldm->swing_idx_ofdm[p];

-			RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,
-				 "pDM_Odm->RFCalibrateInfo.ThermalValue = %d ThermalValue= %d\n",
-				 rtldm->thermalvalue, thermal_value);
+		RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,
+			 "pDM_Odm->RFCalibrateInfo.ThermalValue = %d ThermalValue= %d\n",
+			 rtldm->thermalvalue, thermal_value);
  		/*Record last Power Tracking Thermal Value*/
  		rtldm->thermalvalue = thermal_value;
  	}
This change looks good to me.

Acked-by: Larry Finger <redacted>

Thanks,

Larry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help