Re: linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c: 1851: maybe uninit data ?
From: Larry Finger <hidden>
Date: 2016-03-15 14:33:30
On 03/15/2016 05:50 AM, David Binderman wrote:
Hello there, [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1851]: (error) Uninitialized struct member: gains.gm [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1851]: (error) Uninitialized struct member: gains.pga [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1851]: (error) Uninitialized struct member: gains.pad [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1851]: (error) Uninitialized struct member: gains.dac [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1853]: (error) Uninitialized struct member: gains.gm [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1853]: (error) Uninitialized struct member: gains.pga [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1853]: (error) Uninitialized struct member: gains.pad [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1853]: (error) Uninitialized struct member: gains.dac I've had a look at the code and I can't see how local structure 'gains' get initialised.
It does not get initialized; however, it is only used in calls to lpphy_papd_cal() that does nothing. Thus, no harm, no foul. You should prepare a patch that initializes it to zero in line 1837. Larry