Re: [PATCH] iw: add libnl-tiny support
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2016-03-08 17:00:25
This:
-#if !defined(CONFIG_LIBNL20) && !defined(CONFIG_LIBNL30) +#if !defined(CONFIG_LIBNL20) && !defined(CONFIG_LIBNL30) && !defined(CONFIG_LIBNL_TINY)
-#endif /* CONFIG_LIBNL20 && CONFIG_LIBNL30 */ +#endif /* CONFIG_LIBNL20 && CONFIG_LIBNL30 && CONFIG_LIBNL_TINY */
can be handled by just defining CONFIG_LIBNL20 for libnl-tiny.
-/* libnl 1.x compatibility code */ +/* libnl 1.x and libnl-tiny compatibility code */ #if !defined(CONFIG_LIBNL20) && !defined(CONFIG_LIBNL30) # define nl_sock nl_handle #endif
Are you sure this is needed? Elsewhere you said libnl-tiny uses libnl20 compatible API, which is with nl_handle. If this is needed perhaps some code erroneously uses nl_sock instead of nl_handle? Perhaps we should also consider treating 2.0/3.x as the default API and use nl_handle instead of nl_sock in the code. johannes