Re: [PATCH] staging: rtl8723au: Fix line longer than 80 columns.
From: Joe Perches <joe@perches.com>
Date: 2016-02-27 18:49:04
Also in:
lkml
On Sat, 2016-02-27 at 10:28 -0800, Edward Lipinsky wrote:
This patch fixes the checkpatch.pl warning: WARNING: line over 80 characters
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
[]
quoted hunk ↗ jump to hunk
@@ -1834,7 +1834,8 @@ void stop_ap_mode23a(struct rtw_adapter *padapter)} spin_unlock_bh(&pacl_node_q->lock); - DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, pacl_list->num); + DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, + pacl_list->num);
It's generally nicer to break the line at the end
of the format sting like:
DBG_8723A("%s, free acl_node_queue, num =%d\n",
__func__, pacl_list->num);
though it'd be even better to convert all of these
DBG_8723A uses to pr_debug
$ git ls-files drivers/staging/rtl8723au/ | \
xargs sed -r -i \
-e 's/\bDBG_8723A\b/pr_debug/g' \
-e 's/\bMSG|8723A\b/pr_debug/g'