Thread (4 messages) 4 messages, 4 authors, 2016-03-07

Re: [PATCH][V3] mt7601u: do not free dma_buf when ivp allocation fails

From: Kuba Kicinski <hidden>
Date: 2016-02-25 23:43:22
Also in: linux-arm-kernel, linux-mediatek, lkml, netdev

On 25 February 2016 18:24:27 GMT-05:00, Colin King [off-list ref] wrote:
From: Colin Ian King <redacted>

If the allocation of ivp fails the error handling attempts to
free an uninitialized dma_buf; this data structure just contains
garbage on the stack, so the freeing will cause issues when the
urb, buf and dma fields are free'd. Fix this by not free'ing the
dma_buf if the ivp allocation fails.

Signed-off-by: Colin Ian King <redacted>
LGTM, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help