Thread (1 message) 1 message, 1 author, 2016-02-18

Re: [PATCH v5 0/3] staging: rtl8723au: use list_for_each_entry*() and cleaning

From: Jes Sorensen <hidden>
Date: 2016-02-18 19:09:38
Also in: lkml

Geliang Tang [off-list ref] writes:
On Wed, Feb 17, 2016 at 12:28:33PM -0500, Jes Sorensen wrote:
quoted
kbuild test robot [off-list ref] writes:
quoted
All errors (new ones prefixed by >>):

   drivers/staging/rtl8723au/core/rtw_recv.c: In function 'rtw_free_recvframe23a_queue':
quoted
quoted
drivers/staging/rtl8723au/core/rtw_recv.c:203:2: error: 'plist' undeclared (first use in this function)
     plist = phead->next;
     ^
This doesn't work, you cannot break interim builds. Your patch 2 needs
to go before patch 1, and you must always check that they compile for
each patch you apply.

NACK
Sorry for the trouble caused. I updated my patchs to fix this problem.

- Geliang

This patch set uses list_for_each_entry*() instead of
list_for_each*(), removes useless codes, and cleans
whitespaces and blank lines.
No worries, I much prefer taking a few rounds to get it right.

This set looks good to me.

Acked-by: Jes Sorensen <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help