Re: [PATCH] b43: fix memory leak
From: Michael Büsch <m@bues.ch>
Date: 2016-02-18 16:32:45
Also in:
lkml, netdev
On Thu, 18 Feb 2016 18:04:36 +0530 Sudip Mukherjee [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Sudip Mukherjee <redacted> On error we jumped to the label bcma_out and returned the error code but we missed freeing dev. Signed-off-by: Sudip Mukherjee <redacted> --- drivers/net/wireless/broadcom/b43/main.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c index c279211..78f670a 100644 --- a/drivers/net/wireless/broadcom/b43/main.c +++ b/drivers/net/wireless/broadcom/b43/main.c@@ -5671,6 +5671,7 @@ static int b43_bcma_probe(struct bcma_device *core) wl = b43_wireless_init(dev); if (IS_ERR(wl)) { err = PTR_ERR(wl); + kfree(dev); goto bcma_out; }
We recently had a patch that fixes this, among more leaks. Subject: [PATCH v2 resend] b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init Please test that patch instead, so we can finally apply it. It needs to be tested on both ssb and bcma. Come on. This isn't too hard. :) Please somebody with any hardware test it. (I currently don't have any b43 hardware) -- Michael
Attachments
- (unnamed) [application/pgp-signature] 819 bytes