Thread (6 messages) 6 messages, 3 authors, 2016-02-01

Re: [PATCH 3/3] Staging: rtl8723au: core: rtw_ieee80211: Fixed space and brace coding style issue.

From: Joe Perches <joe@perches.com>
Date: 2016-02-01 14:28:25

On Mon, 2016-02-01 at 07:29 -0500, Jes Sorensen wrote:
Joe Perches [off-list ref] writes:
[]
quoted
so this could be transformed into something like:

int rtw_get_bit_value_from_ieee_value23a(u8 val)
{
	int i;
	static const u8 dot11_rate_table[] = {
		2, 4, 11, 22, 12, 18, 24, 36, 48, 72, 96, 108
	};
and per my previous email, the above is worse than than the original.
The cleaner way to list it would be:

	static const char dot11_rate_table[] =
		{ 2, 4, 11, 22, 12, 18, 24, 36, 48, 72, 96, 108 };
Either style is OK, but the style I used is slightly
more common in the kernel overall, about 2:1.

The type should ideally be u8 and not char.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help