Re: [PATCH v2 3/3] mac80211: Unify mesh and mpp path removal function
From: Henning Rogge <hidden>
Date: 2016-01-31 07:30:33
From: Henning Rogge <hidden>
Date: 2016-01-31 07:30:33
On Sun, Jan 31, 2016 at 12:56 AM, Bob Copeland [off-list ref] wrote:
On Fri, Jan 29, 2016 at 11:08:58AM +0100, Henning Rogge wrote:quoted
@@ -951,37 +974,14 @@ enddel: */ static int mpp_path_del(struct ieee80211_sub_if_data *sdata, const u8 *addr) { - struct mesh_table *tbl; - struct mesh_path *mpath; - struct mpath_node *node; - struct hlist_head *bucket; - int hash_idx; - int err = 0; - - /* flush relevant mpp entries first */ - mpp_flush_by_proxy(sdata, addr); -Is it intentional that mpp_path_del no longer calls mpp_flush_by_proxy() while mesh_path_del does?
You just found a bug in the original patch... the "mpp_flush_by_proxy" is the function that erase all MPP entries going through a certain MPath entry... so it is wrong in the mpp_path_del() function. I will respin the series tomorrow. Henning