Hi Kalle,

From: Kalle Valo [mailto:kvalo@codeaurora.org]
Sent: Tuesday, January 05, 2016 3:41 PM
To: Amitkumar Karwar
Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam; Jeff
CF Chen
Subject: Re: [PATCH 1/3] mwifiex: fix misleading firmware download
messages

Amitkumar Karwar [off-list ref] writes:

quoted

From: chunfan chen <redacted>

mwifiex_check_fw_status() checks firmware status and also check if
WLAN is the winner for firmware downloading.

Once we detect that other interface is downloading the firmware, we
call this routine again with max poll count to wait until firmware is
ready.

This patch splits the routine to avoid checking winner status multiple
times and ensures that correct warning messages are displayed.

Firmware status poll count is also increased to 150.

The title is somewhat misleading, you are doing a lot more than just
fixing messages. Also please clarify the concept here, especially about
"winner", "loser" and the other interface.

Thanks for review. I will submit updated version with below changes.
1) Change title to "mwifiex: firmware download enhancements"
2) Modified description to explain "winner", "loser" and the other interface concepts.

quoted

Signed-off-by: chunfan chen <redacted>

It's good practise to capitalise the name.

Ack.

Regards,
Amitkumar Karwar