Re: pull request: iwlwifi-next 2016-01-07

On 01/07/2016 11:08 PM, Kalle Valo wrote:

"Grumbach, Emmanuel" [off-list ref] writes:

quoted

Me again,

On 01/07/2016 02:46 PM, Grumbach, Emmanuel wrote:

quoted

Hi Kalle,

Here is the last round of patches for 4.5. Most of them are small and / or fixes.
Let me know if you have issues.
FYI - I scripted a few checks so that I hope that the internal tags that leaked
in the previous pull request won't leak any more.

The following changes since commit e5d15cb530082cc13a6c9457eddd6f75b0f4de65:

I had to edit one commit. I re-pushed to the same tag and added another
_2 tag if you prefer to be sure.

Heh, you sent this just in the last minute (if Linus releases 4.4 this
weekend as planned). I pulled iwlwifi-next-for-kalle-2016-01-07_2 now,
thanks.

Right, OTOH, most of the patches here are really fixes.

BTW, I would prefer that you don't change the tag after you have sent a
pull request for it, instead just create a new tag and leave the old one
intact. This way it's easy for me to check what has changed etc.

FWIW:

$ git diff ccecff6..iwlwifi-next-for-kalle-2016-01-07_2

diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/lib.c

b/drivers/net/wireless/intel/iwlwifi/dvm/lib.c
index fd409ad..4841be2 100644

--- a/drivers/net/wireless/intel/iwlwifi/dvm/lib.c
+++ b/drivers/net/wireless/intel/iwlwifi/dvm/lib.c

@@ -1250,7 +1250,6 @@ int iwlagn_suspend(struct iwl_priv *priv, struct

cfg80211_wowlan *wowlan)
 
        ret = iwlagn_send_patterns(priv, wowlan);
  out:
-       iwl_trans_stop_device(priv->trans);
        kfree(key_data.rsc_tsc);
        return ret;
 }